Skip to content

Conversation

@nghaninn
Copy link
Contributor

@nghaninn nghaninn commented Oct 2, 2025


name: Certificate Template Addition
about: This is the workflow for requesting new certificate templates to be added to
the OpenCerts repository
title: "[New Template]"
labels: new template
assignees: ''


Pull Request Guidelines for Adding Certificate Templates

This document is a work in progress but here are some basic checks. As these are only basic guidelines, meeting the below doesn't indicate there will be no issues with your pull request.

Pre-merge checks

  • Did not modify any files outside of your organisation's template folder (e.g package-lock.json or anything else)
  • Ensure that your code has been rebased on top of latest OpenCerts master
  • Linter issues resolved (Run npm run lint:fix to see issues)
  • npm run test passes
  • npm run test:integration passes
  • Travis Build passes

Certificate Template

  • No more than 5 templates or 25 added/modified files in the pull request
  • Ensure that your .opencert file's data complies with the intentions of the OpenCerts' schema - e.g recipient related information is inside the recipient object, etc.
  • Integration test for each template that checks that the correct rendering is done given a sample certificate
  • Sample certificate file included for each template, located alongside the integration test for each template
  • Sample certificates must obviously be a sample certificate
    • Obviously fictitious name
    • Obviously sample signatory images
  • No fixed-size raster images as part of certificate layout
  • Mobile responsive design
  • Date parsing should be localised to template author's timezone
  • Webpack chunking code is correct
    • Has chunking code
    • Same chunking code as the other certificates belonging to that institute
  • Certificate Store Addresses have been updated
    • Template Whitelist
    • Registry
  • Template should not be using resources(images etc.) on the website outside of their own folder (e.g institute logo shouldn't be used from /static because there's no guarantee it will not change)

@nghaninn nghaninn merged commit 4f976e0 into imda Oct 2, 2025
1 of 5 checks passed
@nghaninn nghaninn deleted the temp/disable-email branch October 2, 2025 07:03
isaackps pushed a commit that referenced this pull request Nov 4, 2025
isaackps added a commit that referenced this pull request Nov 4, 2025
* chore: update wordings from GovTech -> IMDA (#823)

* fix: add maintenance notice (#824)

* fix: update readme (#825)

* feat: added github actions to deploy to s3 bucket

* fix: syntax error

* fix: if error

* fix: remove optional

* fix: update deploy s3 dev actions

* fix: update deploy prod yml

* fix: indent

* fix: secrets

* fix: if statement

* fix: env

* fix: update actions name

* fix: combine dev and prod

* fix: update file

* fix: update different artifact for dev and prod

* fix: update recaptcha client key

* fix: update opencerts-verify package

* fix: update code

* fix: disable email (#826)

* fix: re-enable email

* fix: update CICD pipeline

* fix: update readme

* fix: update ci to run lint and test first

* fix: update dev env actions

* fix: update prod deployment script

* fix: update dev api end point

* fix: dev actions (#827)

* fix: remove wogaa from OC

* fix: update github actions for dev

* fix: update prod deployment script to be manually triggered (#828)

---------

Co-authored-by: Kyle Huang Junyuan <[email protected]>
Co-authored-by: Ng Han Inn <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2025
isaackps added a commit that referenced this pull request Nov 5, 2025
* feat: added github actions to deploy to s3 bucket

* fix: syntax error

* fix: if error

* fix: remove optional

* fix: update deploy s3 dev actions

* fix: update deploy prod yml

* fix: indent

* fix: secrets

* fix: if statement

* fix: env

* fix: update actions name

* fix: combine dev and prod

* fix: update file

* fix: update different artifact for dev and prod

* chore: update wordings from GovTech -> IMDA (#823)

* fix: add maintenance notice (#824)

* fix: update readme (#825)

* fix: update recaptcha client key

* fix: update opencerts-verify package

* fix: update code

* fix: disable email (#826)

* fix: re-enable email

* fix: update CICD pipeline

* fix: update readme

* fix: update ci to run lint and test first

* fix: update dev env actions

* fix: update prod deployment script

* fix: update dev api end point

* fix: dev actions (#827)

* fix: remove wogaa from OC

* fix: update github actions for dev

* fix: update prod deployment script to be manually triggered (#828)

* Fix/branch develop (#830)

* chore: update wordings from GovTech -> IMDA (#823)

* fix: add maintenance notice (#824)

* fix: update readme (#825)

* feat: added github actions to deploy to s3 bucket

* fix: syntax error

* fix: if error

* fix: remove optional

* fix: update deploy s3 dev actions

* fix: update deploy prod yml

* fix: indent

* fix: secrets

* fix: if statement

* fix: env

* fix: update actions name

* fix: combine dev and prod

* fix: update file

* fix: update different artifact for dev and prod

* fix: update recaptcha client key

* fix: update opencerts-verify package

* fix: update code

* fix: disable email (#826)

* fix: re-enable email

* fix: update CICD pipeline

* fix: update readme

* fix: update ci to run lint and test first

* fix: update dev env actions

* fix: update prod deployment script

* fix: update dev api end point

* fix: dev actions (#827)

* fix: remove wogaa from OC

* fix: update github actions for dev

* fix: update prod deployment script to be manually triggered (#828)

---------

Co-authored-by: Kyle Huang Junyuan <[email protected]>
Co-authored-by: Ng Han Inn <[email protected]>

---------

Co-authored-by: Kyle Huang Junyuan <[email protected]>
Co-authored-by: Ng Han Inn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants